Include cross-parameter violations in hasErrors() and getAllErrors()#36672
Closed
tianhaocui wants to merge 1 commit into
Closed
Include cross-parameter violations in hasErrors() and getAllErrors()#36672tianhaocui wants to merge 1 commit into
tianhaocui wants to merge 1 commit into
Conversation
MethodValidationResult.hasErrors() only checked getParameterValidationResults(), ignoring cross-parameter constraint violations entirely. Similarly, getAllErrors() only collected errors from per-parameter results. When adapt-constraint-violations is enabled, cross-parameter violations are stored separately via getCrossParameterValidationResults(). Both hasErrors() and getAllErrors() now include these results so that cross-parameter constraint violations are properly surfaced. Closes spring-projects#36666 Signed-off-by: cuitianhao <54015884+tianhaocui@users.noreply.github.com>
tianhaocui
force-pushed
the
fix-cross-parameter-validation-errors
branch
from
6e239f0 to
7aca8be
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Thanks for the change but this issue requires a deeper review, and is not open for contribution. |
rstoyanchev
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36666
MethodValidationResult.hasErrors()only checkedgetParameterValidationResults(), completely ignoring cross-parameter constraint violations. Similarly,getAllErrors()only collected errors from per-parameter results.When
adapt-constraint-violationsis enabled, cross-parameter violations are stored separately viagetCrossParameterValidationResults(). This causedhasErrors()to returnfalseandgetAllErrors()to return an empty list even when cross-parameter violations were present, effectively swallowing these errors.Changes:
hasErrors()now also checksgetCrossParameterValidationResults()getAllErrors()now includes cross-parameter errors viaStream.concat